Attention is currently required from: Anastasia Klimchuk, Angel Pons, Evan Benn, Hsuan Ting Chen.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82231?usp=email )
Change subject: flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi Anastasia and Angel:
Previously, we could only test the tests under util/flashrom-tester/flashrom/src/cmd.rs by running `cargo test` under `flashrom` library, and thus we have no way for ChromeOS to support running them.
I added the workspace in flashrom-tester, this could allow us to unit test easier both in ChromeOS (default emerge) and UPSTREAM (`cargo test --workspace`)
Please help me review this patch,
Thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic23bc35592e6d7d8dd24c71630ea9a2eb2d58573
Gerrit-Change-Number: 82231
Gerrit-PatchSet: 4
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evan Benn
evanbenn@gmail.com
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Evan Benn
evanbenn@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 07 May 2024 11:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment