Nico Huber has posted comments on this change. ( https://review.coreboot.org/22263 )
Change subject: vt_vx: check whether the chipset's MMIO range is configured
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/22263/2/chipset_enable.c
File chipset_enable.c:
https://review.coreboot.org/#/c/22263/2/chipset_enable.c@1040
PS2, Line 1040: spi0_mm_base = spi_cntl & 0xFFFFFF00;
You could check for 0 here, too.
--
To view, visit
https://review.coreboot.org/22263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293
Gerrit-Change-Number: 22263
Gerrit-PatchSet: 2
Gerrit-Owner: Lubomir Rintel
lkundrak@v3.sk
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Dec 2017 22:21:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes