Change in flashrom[master]: [v4, 5/6] Add the hidden-from-probing chips category and make KB9012 h... - flashrom-gerrit

2 Feb 2018


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/23262 )
Change subject: [v4,5/6] Add the hidden-from-probing chips category and make KB9012 hidden
......................................................................
Patch Set 1:
IMHO, taking shortcuts is one of the problems that made flashrom less
maintainable and makes merging of new patches much harder. Usually,
the time you spend to do something right from the beginning pays off
later. If you want, I can take this one commit over and you'd only
have to rebase the others on it.
-- 
To view, visit https://review.coreboot.org/23262
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0
Gerrit-Change-Number: 23262
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Kocialkowski contact@paulk.fr
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 02 Feb 2018 22:33:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No