Attention is currently required from: Sam McNally, Nico Huber, Rizwan Qureshi, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support ......................................................................
Patch Set 13:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62251/comment/396dfb6b_42153b0d PS12, Line 12: TEST=```localhost ~ # flashrom --flash-name
Thanks for that detail. […]
Added to commit message, thanks Sam for following up with the hardware!
Patchset:
PS12:
So far I've seen no difference beside the number of straps in the descriptor.
Probably best to start with a new enum and collapse down as a optimisation patch as a follow up rather than prematurely. It looks like a large amount of enum optimisation could be had in the ich code in general so seems better to either do the entire refactor chain totally and not half baked WDYT?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62251/comment/984bff90_6fa6b3ca PS12, Line 307: case CHIPSET_600_SERIES_ALDER_POINT:
From the values available in the FIT tool, I think you're right.
Good spot, case was on the wrong line, It meant for it to be under 500, Fixed.
-
Edward O'Callaghan (Code Review)