[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
Attention is currently required from: Shreeyash .
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66225/comment/b13f2119_88ef031d PS2, Line 7: Bug fix, Initialize uninitialized pointers How about `fix false-positive compiler error`?
https://review.coreboot.org/c/flashrom/+/66225/comment/47e0cde9_29b83bb9 PS2, Line 9: on line 510 After rebasing, the line number is not correct. I suggest deleting it.
Patchset:
PS2: Please have a look at CB:67700 (especially on unresolved comments). This patch does the same, so it's a clone.
You should rewrite the commit message to point out that it's false-positive case.
Because then it's not a fix for anything in flashrom, certainly not a bug fix, but a workaround to assist limited path analysis. (C) Nico Huber
If you want, you can use the commit message from the patch I mentioned earlier.
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/aee760f5_769d9277 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
I think both the issues have been 'fixed'. […]
Add the comment that Thomas suggests to you. But put it before the variable, otherwise 112-columns hard limit will be broken.
`/* Initialize stlinkv3_handle to NULL for suppressing scan-build false positive core.uninitialized.Branch */`
Thomas, can we get rid of `core.uninitialized.Branch`? It doesn't suppress the warning :D
-
Alexander Goncharov (Code Review)