Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm ......................................................................
Patch Set 45:
(7 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/caf3ebe8_618b2039 PS43, Line 1054: assert(!ret);
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/d49c2693_bd1bbf64 PS43, Line 1055: //verify erase : ret = check_erased_range(flashctx, start_addr, block_len); : assert(!ret); : //if erase fail?? : //
This is not needed, there is a verify command at the end.
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/9a3f10e2_5874d601 PS43, Line 1065: msg_cinfo
s/msg_cdbg/
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/da20931d_ef7b04e9 PS43, Line 1076: assert(!ret);
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/679a6742_28c3de8b PS43, Line 1078: ret = verify_range(flashctx, newcontents + i, i, flashctx->chip->page_size); : assert(!ret);
This is not needed, there is a verify command at the end.
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/790f0fd9_609c2917 PS43, Line 1082: msg_cinfo
s/msg_cdbg/
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/02374eb4_f7a392a9 PS43, Line 1088: assert(!ret);
Done