Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33668
Change subject: tree: Include missing headers for function prototypes ......................................................................
tree: Include missing headers for function prototypes
These files all contain functions whose prototypes are in header files, so make sure those header files are included.
Change-Id: I0189a1550bf90d4a0b87dcef9f8a8449590cc9d7 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M edi.c M hwaccess.c M sst_fwhub.c M udelay.c M w29ee011.c 5 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/33668/1
diff --git a/edi.c b/edi.c index bd5b269..a2219ac 100644 --- a/edi.c +++ b/edi.c @@ -16,6 +16,7 @@
#include <string.h> #include "flash.h" +#include "chipdrivers.h" #include "ene.h" #include "edi.h"
diff --git a/hwaccess.c b/hwaccess.c index bb5aac4..48ccb34 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -27,6 +27,7 @@ #include <fcntl.h> #endif #include "flash.h" +#include "programmer.h" #include "hwaccess.h"
#if !(IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun) || defined(__gnu_hurd__)) diff --git a/sst_fwhub.c b/sst_fwhub.c index 398b01b..c712303 100644 --- a/sst_fwhub.c +++ b/sst_fwhub.c @@ -19,6 +19,7 @@ /* Adapted from the Intel FW hub stuff for 82802ax parts. */
#include "flash.h" +#include "chipdrivers.h"
static int check_sst_fwhub_block_lock(struct flashctx *flash, int offset) { diff --git a/udelay.c b/udelay.c index f6fd103..6c0efc4 100644 --- a/udelay.c +++ b/udelay.c @@ -25,6 +25,7 @@ #include <stdlib.h> #include <limits.h> #include "flash.h" +#include "programmer.h"
static bool use_clock_gettime = false;
diff --git a/w29ee011.c b/w29ee011.c index 8a62e4c..a570bd6 100644 --- a/w29ee011.c +++ b/w29ee011.c @@ -16,6 +16,7 @@
#include <string.h> #include "flash.h" +#include "chipdrivers.h"
/* According to the Winbond W29EE011, W29EE012, W29C010M, W29C011A * datasheets this is the only valid probe function for those chips.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33668 )
Change subject: tree: Include missing headers for function prototypes ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33668 )
Change subject: tree: Include missing headers for function prototypes ......................................................................
tree: Include missing headers for function prototypes
These files all contain functions whose prototypes are in header files, so make sure those header files are included.
Change-Id: I0189a1550bf90d4a0b87dcef9f8a8449590cc9d7 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/flashrom/+/33668 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M edi.c M hwaccess.c M sst_fwhub.c M udelay.c M w29ee011.c 5 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/edi.c b/edi.c index bd5b269..a2219ac 100644 --- a/edi.c +++ b/edi.c @@ -16,6 +16,7 @@
#include <string.h> #include "flash.h" +#include "chipdrivers.h" #include "ene.h" #include "edi.h"
diff --git a/hwaccess.c b/hwaccess.c index bb5aac4..48ccb34 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -27,6 +27,7 @@ #include <fcntl.h> #endif #include "flash.h" +#include "programmer.h" #include "hwaccess.h"
#if !(IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun) || defined(__gnu_hurd__)) diff --git a/sst_fwhub.c b/sst_fwhub.c index 398b01b..c712303 100644 --- a/sst_fwhub.c +++ b/sst_fwhub.c @@ -19,6 +19,7 @@ /* Adapted from the Intel FW hub stuff for 82802ax parts. */
#include "flash.h" +#include "chipdrivers.h"
static int check_sst_fwhub_block_lock(struct flashctx *flash, int offset) { diff --git a/udelay.c b/udelay.c index f6fd103..6c0efc4 100644 --- a/udelay.c +++ b/udelay.c @@ -25,6 +25,7 @@ #include <stdlib.h> #include <limits.h> #include "flash.h" +#include "programmer.h"
static bool use_clock_gettime = false;
diff --git a/w29ee011.c b/w29ee011.c index 8a62e4c..a570bd6 100644 --- a/w29ee011.c +++ b/w29ee011.c @@ -16,6 +16,7 @@
#include <string.h> #include "flash.h" +#include "chipdrivers.h"
/* According to the Winbond W29EE011, W29EE012, W29C010M, W29C011A * datasheets this is the only valid probe function for those chips.
-
Jacob Garber (Code Review) -
Nico Huber (Code Review)