Attention is currently required from: Stefan Reinauer, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54943 )
Change subject: Add AmigaOS suppport to flashrom ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54943/comment/6135aced_0a26ca71 PS1, Line 8:
I assume we can get by with compile testing, not runtime testing? That can be done with a cross compiler (albeit there is no prebuilt version for this)
Yeah, manibuilder only does build testing. A cross compiler would work. The DJGPP target is already using a cross-compiler.
How would I do this? Create a Dockerfile.amiga that contains a crosscompile environment?
I have no idea how Docker works. I would ask Nico for advice.
What's this anita stuff?
http://www.gson.org/netbsd/anita/
File Makefile:
https://review.coreboot.org/c/flashrom/+/54943/comment/d5bfc693_03c8edcc PS1, Line 141: Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support).
This code is copied verbatim from the MSDOS section. […]
I'm actually bothered by the comment, not the code ;)
(or should I say Make-foo instead?)
File flash.h:
https://review.coreboot.org/c/flashrom/+/54943/comment/920eedf8_f6c89262 PS1, Line 56: __AMIGA__
I don't know. […]
I'm not aware of any rule, it's probably "organic" code growth. It just felt odd that every introduced guard uses `IS_AMIGA`, except for this one.
-
Angel Pons (Code Review)