Change in flashrom[master]: tree: Remove forward-declarations of structs for spi masters

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51731 )

Change subject: tree: Remove forward-declarations of structs for spi masters
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS1:
> +1 to Nico's suggestion, that is precisely how we check these things. […]
> Thank you! I will test like this in future.
> What I got comparing before and after:
> objdump -d is identical
> objdump -s only difference is version number

30362,30363c30362,30363
<  00d0 76312e32 2d323233 2d676138 33303136  v1.2-223-ga83016
<  00e0 3600                                 6.              
---
> 00d0 76312e32 2d323234 2d673062 63306631  v1.2-224-g0bc0f1
>  00e0 6500                                 e.

I don't see the difference in .note.gnu.build-id , do you know why (the difference Nico sees and I don't have it)?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I256bd7c763efc010fc1f29f7c5853f150ac10739
Gerrit-Change-Number: 51731
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Comment-Date: Tue, 30 Mar 2021 05:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: comment