Change in flashrom[master]: print.c: Dedup 'test_state_to_text()' logic

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

print.c: Dedup 'test_state_to_text()' logic

Change-Id: I72164323d7ff98fc50cb0c47b69741a4f047e098
Signed-off-by: Edward O'Callaghan 
---
M print.c
1 file changed, 1 insertion(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/36905/1

diff --git a/print.c b/print.c
index 6a7ff5d..596fc53 100644
--- a/print.c
+++ b/print.c
@@ -401,14 +401,7 @@
    	for (i = 0; i < maxboardlen - strlen(b->name); i++)
    		msg_ginfo(" ");

-		switch (b->working) {
-		case OK:  msg_ginfo("OK      "); break;
-		case NT:  msg_ginfo("NT      "); break;
-		case DEP: msg_ginfo("DEP     "); break;
-		case NA:  msg_ginfo("N/A     "); break;
-		case BAD:
-		default:  msg_ginfo("BAD     "); break;
-		}
+		msg_pinfo(test_state_to_text(b->working));

for (e = board_matches; e->vendor_name != NULL; e++) {
    		if (strcmp(e->vendor_name, b->vendor)

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

Patch Set 1: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

print.c: Dedup 'test_state_to_text()' logic

Change-Id: I72164323d7ff98fc50cb0c47b69741a4f047e098
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/36905
Tested-by: build bot (Jenkins) 
Reviewed-by: David Hendricks 
---
M print.c
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved

diff --git a/print.c b/print.c
index 6a7ff5d..596fc53 100644
--- a/print.c
+++ b/print.c
@@ -401,14 +401,7 @@
    	for (i = 0; i < maxboardlen - strlen(b->name); i++)
    		msg_ginfo(" ");

-		switch (b->working) {
-		case OK:  msg_ginfo("OK      "); break;
-		case NT:  msg_ginfo("NT      "); break;
-		case DEP: msg_ginfo("DEP     "); break;
-		case NA:  msg_ginfo("N/A     "); break;
-		case BAD:
-		default:  msg_ginfo("BAD     "); break;
-		}
+		msg_pinfo(test_state_to_text(b->working));

for (e = board_matches; e->vendor_name != NULL; e++) {
    		if (strcmp(e->vendor_name, b->vendor)

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

Patch Set 2:

um, -2?

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

Patch Set 2:
> Patch Set 2:
>
> um, -2?

Why?

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36905 )

Change subject: print.c: Dedup 'test_state_to_text()' logic
......................................................................

Patch Set 2:

Ah, I see now (CB:36909)