[XS] Change in flashrom[main]: erasure_layout: Fix unaligned region end offset by 1 - flashrom-gerrit

9 Nov 2023


      Attention is currently required from: Aarya, Alexander Goncharov, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78984?usp=email )
Change subject: erasure_layout: Fix unaligned region end offset by 1
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1: 
I had to study this a bit to understand what's happening, but I see now that the issue stems from how bounds for an operation are inclusive so starting from `old_end` will start from the last byte of the region to be erased.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/78984?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7f78a0090065cd2a952cba1a5d28179483ba4c55
Gerrit-Change-Number: 78984
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Thu, 09 Nov 2023 22:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment