Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82332?usp=email )
Change subject: flashchips: Add support for chip model GD25LF128E
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/82332/comment/3cc45823_5d7eb072 :
PS1, Line 7: Add (or update) chip models <list models>
For this commit you can be more specific, because you know what model you adding. […]
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82332/comment/b31f8253_04492922 :
PS1, Line 6506: .model_id = GIGADEVICE_GD25LF128E,
This macro should be added in the same patch as chip definition. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I71fdc7ea1aea69d14db6af3bac2da3e7bee8abbe
Gerrit-Change-Number: 82332
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Lim
vlim@gigadevice.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Victor Lim
vlim@gigadevice.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Fri, 17 May 2024 12:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment