Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email )
Change subject: udelay: only use OS time for delays, except on DOS ......................................................................
Patch Set 9:
(1 comment)
File tests/udelay.c:
https://review.coreboot.org/c/flashrom/+/81545/comment/c32557d5_cb836fec : PS9, Line 41: This test could fail spuriously on a heavily-loaded system
Carrying a patch to the test on ChromeOS seems okay to me, but I'm not particularly attached to test […]
Okay I have some more thoughts. What would happens if later there is a change that by accident makes the loop infinite, would the test fail on such a change, without upper bound? Probably will result in timeout in tests, but that means tests take super long time to run. In other words, I am thinking, maybe having any upper bound is better than having none at all, because it will assert the loop is not infinite. I agree to add 00 to the upper bound, better than dropping it at all. What do you think, is this a useful thought?
-
Anastasia Klimchuk (Code Review)