Nico Huber has posted comments on this change. ( https://review.coreboot.org/18925 )
Change subject: chipset_enable: Add support for Intel Skylake / Kabylake ......................................................................
Patch Set 6:
One issue I'm having with this code is that it will segfault at the end. I've tracked it down to the rpci_write_byte in enable_flash_ich_bios_cntl_common which calls register_undo_pci_write_byte which saves a copy of the pci device, but the copy is wrong (pci accessor is somehow set to -1) and it segfaults when it tries to restore the pci register in the shutdown handlers.
Thanks for testing and the investigation :)
I'm not yet sure how to properly fix this.
Actually it was correct in the earlier patch versions. I just forgot about the rpci_* when restructuring it. Should be fixed now, haven't retested yet.