Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55266 )
Change subject: treewide: Drop most cases of `sizeof(struct ...)` ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/55266/comment/108391d1_20fb8811 PS1, Line 1242: memcpy(flash->chip, chip, sizeof(*flash->chip)); NB. could even use an assignment w/o bypassing typechecks?
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/55266/comment/e7bc05da_7a53f336 PS1, Line 1734: memset(&desc, 0x00, sizeof(desc)); Or initialize with `= { 0 }`.
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/55266/comment/dfa42b66_01def160 PS1, Line 1594: memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config)); NB. could even use an assignment w/o bypassing typechecks?
-
Nico Huber (Code Review)