Attention is currently required from: Edward O'Callaghan, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52883 )
Change subject: RFC: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Further explanation of the reasons for this change:
These chip entries are some of the last differences between cros and upstream flashrom - resolving them will get us extremely close to fully deforking the flashchips.{c,h} files.
We also tried bringing the duplicate chip into cros flashrom, but that caused issues with flashchip identification, and resolving it would be likely to significantly delay resyncing flashchips.c.
This patch does remove the FEATURE_QPI feature bit (since only 'C' chips had it), however (AFAIK) that feature flag is currently unused, and the chip's capabilities are still recorded in the comments. An additional advantage of this approach is that it generally makes flashrom easier to use.