Attention is currently required from: Brian Norris, Nikolai Artemiev, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
Change subject: flashrom: Don't throw around "delay 1 second" so lightly ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1: I just thought of something and decided to check... Erase operation verifies the chip straight away after erasing. Without any delay. (Also without respecting the noverify flags, but this we will fix later). From the chip point of view, erase is almost the same as write, is that correct? So maybe the erase flow is kind of a "proof-of-concept" for what this patch is doing?
I completely forgot that write and verify can be separated in a manual workflow, so silly of me. This changes the situation, maybe we don't need a special option.
do you want me to start such a mailing list thread, or were you suggesting I do this?
Brian, you gave me two options which are the same :) But I agree with both of them. I think you should start the thread. This was your idea, your work and you even went through 10yr old commit messages! Add a link to the patch in the post, so that anyone who is interested can easily click.
-
Anastasia Klimchuk (Code Review)