Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51706 )
Change subject: dediprog.c: Split up compound conditional statement ......................................................................
Patch Set 1:
(1 comment)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/51706/comment/6683d311_a2929819 PS1, Line 1276: if (register_spi_master(&spi_master_dediprog)) : return 1; : : return dediprog_set_leds(LED_NONE);
Probably not worth to merge this as is if we are going […]
Returning back to this patch, because I think it is a very good idea to split compound conditional statement. Dediprog has changed a bit since March but compound statement is still present. I would really want to split it, and the last line can be `return register_spi_master(....)` as it is in most of spi masters now.
Those are technically two things: split compound statement and switch the order of two operations, can this be done in one patch, what do you think?
Another thing, Angel do you plan to work on this patch in the nearest future? It would be so great to do the last step for dediprog, so we can check it's "done", I am happy to do this, but of course I don't want to steal your work if you plan to do this! Tell me if you want me to do this.
Thank you!!
-
Anastasia Klimchuk (Code Review)