Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87341?usp=email )
Change subject: libflashrom: Add probing v2 which can find all mathching chips ......................................................................
Patch Set 1:
(3 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/87341/comment/e63e4059_68640d19?usp... : PS1, Line 1050: struct flashctx flashes[8] = {{0}}; This array won't be needed after this patch, in the next commit it can be replaced with just one flash context. It was only one context that was used, the rest was needed for probing only. The probing (and temp contexts) is now inside libflashrom.
https://review.coreboot.org/c/flashrom/+/87341/comment/dd130a42_9d8b13ce?usp... : PS1, Line 1215: flashrom_flash_probe_v2 Check the return value
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/87341/comment/71579532_f4ea7535?usp... : PS1, Line 27: flashrom_flash_probe_v2 Tests needs to be added (not replaced), leave existing probing tests and add new for v2.