Change in flashrom[master]: Makefile: use STRIP_ARGS = -s on all platforms - flashrom-gerrit

12 Oct 2021


      Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58246 )
Change subject: Makefile: use STRIP_ARGS = -s on all platforms
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58246/comment/6d810a1c_ac2abdbe 
PS1, Line 9: Strip-all should be the default behavior of strip, but not all systems
           : support this. Use -s (--strip-all) on all systems to not depend on default behavior.
This is confusing. Please explain why you are making it the default even if it's not supported on all systems.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58246
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c80d553fb54d94bc65f07e700c90dd1bae4854e
Gerrit-Change-Number: 58246
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 18:41:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment