[S] Change in flashrom[master]: [WIP] Emulate multithreading env for unit tests on OpenBSD
Attention is currently required from: Thomas Heijligen, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74157 )
Change subject: [WIP] Emulate multithreading env for unit tests on OpenBSD ......................................................................
Patch Set 2:
(3 comments)
This change is ready for review.
Patchset:
PS2: Good news: tests pass on OpenBSD with the patchset2! I want however to try and reduce the number of `#` here, maybe merge all BSDs hacks into one, maybe hiding them in separate c file.
A wilder idea: maybe we can just always unconditionally create "doing nothing" thread (for all OSes), how bad that would be? Which would be the same code but without `#`
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/74157/comment/4d5c538b_9d86f85d PS1, Line 114: '-lpthread',
The meson documentation says you should use `dependency('threads')` for this: https://mesonbuild. […]
Peter, thank you so much, this really helped! this is what was missing!
https://review.coreboot.org/c/flashrom/+/74157/comment/1ae61daa_256e234e PS1, Line 124: '-Dpthread',
This is causing your problem; it makes the preprocessor expand `struct pthread;` to `struct ;`. […]
Thank you! For some reason, tests pass even without including `sys/time.h`. Could that be because it is already included via some other include?
-
Anastasia Klimchuk (Code Review)