Attention is currently required from: Simon Buhrow, Nico Huber, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ......................................................................
Patch Set 24:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/83a59af5_9961d551 PS24, Line 1088: for (i = 0; i < NUM_ERASEFUNCTIONS; i++) { Suggestion:
``` for (int i = 0; check_block_eraser(flashctx, i, 0) == 0, i++) { struct block_eraser eraser = flash->chip->block_erasers[i]; ... while(addr < chip->total_size * 1024) { block_count += erasers.eraseblocks[j].count; addr += erasers.eraseblocks[j].size * erasers.eraseblocks[j].count; } } ``` So you have only one array index at a time in a loop.