Attention is currently required from: Khoa Hoang, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 )
Change subject: flashchips.c: Add write protect support for W25Q16.V
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/67713/comment/98e4b500_74e69a50
PS4, Line 17543: .sec = {STATUS1, 6, RW},
Maybe we should add `.wps = {STATUS3, 2, RW},` but I'm not sure if all versions of this chip support it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Gerrit-Change-Number: 67713
Gerrit-PatchSet: 4
Gerrit-Owner: Khoa Hoang
admin@khoahoang.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Khoa Hoang
admin@khoahoang.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 27 Sep 2022 00:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment