Attention is currently required from: Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81606?usp=email )
Change subject: Make sleep threshold for delays configurable
......................................................................
Patch Set 4:
(2 comments)
File tests/udelay.c:
https://review.coreboot.org/c/flashrom/+/81606/comment/fa51b879_bd7bdbb4 :
PS2, Line 52: if (delay_us >= CONFIG_DELAY_MINIMUM_SLEEP_US)
The test always takes at least as long to run as the chosen delay time, so 0. […]
I am now re-reading and don't understand myself what I was asking :D
File udelay_dos.c:
https://review.coreboot.org/c/flashrom/+/81606/comment/6bf73c6e_85bac27b :
PS4, Line 161: CONFIG_DELAY_MINIMUM_SLEEP_US
probably also needs the same `static const` trick?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc
Gerrit-Change-Number: 81606
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 03 May 2024 08:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment