Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 )
Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
I'm not happy with this and would like to see it fixed instead of merging this hack.
Alright, as we agreed, I will fix https://ticket.coreboot.org/issues/365 first.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Namyoon Woo
namyoon@google.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 09 May 2022 00:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment