[S] Change in flashrom[master]: flashrom.c: Reduce the prog global state machine - flashrom-gerrit

15 Jan 2023


      Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70603 )
Change subject: flashrom.c: Reduce the prog global state machine
......................................................................
Patch Set 2:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/70603/comment/834d955a_16b10c6b 
PS1, Line 41: g_programmer_type
...
Since this is a bool, I would name this `g_is_internal_programmer`. […]
Well this is ephemeral, I wouldn't wrangle over the perfect name, the `_type` suffix is meant to give disambiguation from the `g_programmer`.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70603
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93dfe09fe877acd32c4f22665921544ccd9323f6
Gerrit-Change-Number: 70603
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Jan 2023 01:24:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment