Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67717 )
Change subject: spi.c: Add AT45 & SF25F erasefn opcode mapping ......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6: I would just squash this and the two previous patches together. There is no benefit to having them separate and actually introduces the possibility of subtle things leaking though review like that NULL.
File spi.c:
https://review.coreboot.org/c/flashrom/+/67717/comment/e2e3c4d2_66e1fe1c PS6, Line 229: Assuming 0x00 ..
https://review.coreboot.org/c/flashrom/+/67717/comment/2adc1ada_10f71bcd PS6, Line 229: 0x00 `NULL`
-
Edward O'Callaghan (Code Review)