Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81970?usp=email )
Change subject: <Flashrom SPI NOR>: adding a few new SPI NOR part numbers ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Victor, this is amazing, thank you so much for adding and updating so many chips!
What you need to do now, is to split this large patch into several smaller ones. I can see some of the models are related and can be grouped together. So for example, GD25LB128E, GD25LQ128E, GD25LR128E can be in one patch. And then GD25LB256F, GD25LQ256H, GD25LR256F can be in the next patch, and so on.
When you split your git commit locally, you will have a chain of commits in your local branch. And then when you push the whole chain to Gerrit, you will see all the patches in a chain as well.
For commit titles, you can use the pattern:
`flashchips: Add (or update) chip models <list models>`
Another thing is, you need to provide links to public datasheets for the models added or updated in each patch. Thanks!
-
Anastasia Klimchuk (Code Review)