Attention is currently required from: Anastasia Klimchuk, Brian Norris, Peter Marheine.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
Change subject: flashrom: Don't throw around "delay 1 second" so lightly ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
Unfortunately, this hack survived so long it migrated from the CLI to the library. […]
I'd avoid adding a flag - if there really are chips that need a delay, then there is a hardware or software bug that should be addressed with a chip flag or driver fix instead. Adding a flag makes a temporary fix more permanent.
If users need to flash a buggy chip and can't wait for a new flashrom version that fixes it, they can always separate the write & verify operations as Brian suggests.
A mailing list post seems like a good option for trying to recover the history around why the delay was added. If we don't get any response there within say 1 week, then I think we should just land this patch.
-
Nikolai Artemiev (Code Review)