Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Samantaz Fox has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83969?usp=email )
Change subject: flashchips: Add definitions for Fudan FM25Q04, FM25Q64 and FM25Q128
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
I've made the requested changes 😊
Commit Message:
https://review.coreboot.org/c/flashrom/+/83969/comment/f3f51d23_d9d1dbc4?usp... :
PS1, Line 7: Fuldan
Fuldan -> Fudan (a typo)
Done
https://review.coreboot.org/c/flashrom/+/83969/comment/f867f705_b02c4192?usp... :
PS1, Line 9: These chips have the exact same characteristics as their 8/16/32 counterparts,
: except for the different flash size.
Do you have link to the datasheet, if you could add a link in commit message? […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83969?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I88fcc2bbb9706c8adb3722da6aa0e1d2d04c3fde
Gerrit-Change-Number: 83969
Gerrit-PatchSet: 2
Gerrit-Owner: Samantaz Fox
coding@samantaz.fr
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 18:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org