Change in flashrom[master]: ichspi.c: Implement read_write_status for wp - flashrom-gerrit

23 May 2022


      Attention is currently required from: Subrata Banik, Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64540 )
Change subject: ichspi.c: Implement read_write_status for wp
......................................................................
Patch Set 2:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/64540/comment/28e8c344_29c2ae91 
PS1, Line 122: FIXME(quasisec): Port to new macros? - Control bits
...
...
@Subrata, what did you suggest downstream to clean this up here? […]
Thanks Subrata, hopefully the updated patch addresses the issue?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ecbe8491ecea3697922c91af26ca62276e86317
Gerrit-Change-Number: 64540
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 23 May 2022 02:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment