Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40969 )
Change subject: raiden_debug_spi: Fix memleak ......................................................................
raiden_debug_spi: Fix memleak
Change-Id: Ib9d99fefda812d20265db47be353c844f8b77129 Found-by: Coverity Scan #1420204 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M raiden_debug_spi.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/40969/1
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 306d8fb..57cc659 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -467,8 +467,10 @@ int ret;
int request_enable = get_target(); - if (request_enable < 0) + if (request_enable < 0) { + free(serial); return 1; + }
usb_match_init(&match);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40969 )
Change subject: raiden_debug_spi: Fix memleak ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40969 )
Change subject: raiden_debug_spi: Fix memleak ......................................................................
raiden_debug_spi: Fix memleak
Change-Id: Ib9d99fefda812d20265db47be353c844f8b77129 Found-by: Coverity Scan #1420204 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/40969 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M raiden_debug_spi.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 368476f..2127f69 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -480,8 +480,10 @@ int ret;
int request_enable = get_target(); - if (request_enable < 0) + if (request_enable < 0) { + free(serial); return 1; + }
usb_match_init(&match);