Change in flashrom[master]: [RFC] ich_descriptors: Don't base chipset detection on `freq_read` - flashrom-gerrit

18 Jun 2021


      Attention is currently required from: Nico Huber, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55650 )
Change subject: [RFC] ich_descriptors: Don't base chipset detection on `freq_read`
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2: 
I agree, using freq_read is more error prone. Simply warning the user should be enough.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55650
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I658d76ec2567d1d660a18d0b0ae71c744e603e8f
Gerrit-Change-Number: 55650
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 18 Jun 2021 08:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment