[S] Change in flashrom[main]: libflashrom: Fix comparison of layout romentry regions - flashrom-gerrit

26 Nov 2024


      Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85292?usp=email )
Change subject: libflashrom: Fix comparison of layout romentry regions
......................................................................
Patch Set 1:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/85292/comment/c1a1ccc7_5db26e7f?usp... :
PS1, Line 309: static int compare_region_with_dump(const struct romentry *const a, const struct romentry *const b)
...
It should always be zeroed, but that's true because `flashrom_layout_new` uses `calloc` and that doe […]
Alright, then I leave it as is. Thank you.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/85292?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I715969036c8e516aac8d90b46830f1f92ae6a160
Gerrit-Change-Number: 85292
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Nov 2024 01:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org