Change in flashrom[master]: util/shell.nix: Add libjaylink - flashrom-gerrit

15 May 2022


      Attention is currently required from: Paul Menzel, Thomas Heijligen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64352 )
Change subject: util/shell.nix: Add libjaylink
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
PS2:
...
Please mention older NixOS versions are eol.
What have older NixOS versions to do with this here? Seems unrelated to me.
https://review.coreboot.org/c/flashrom/+/64352/comment/17063b1f_c81cab9f 
PS2, Line 9: remove the comment and
           : include the package libjaylink
...
The hash in the beginning is easily overlooked, so maybe say “activate the line” or something simila […]
I think using "include" is fine.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64352
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I56e750831143a4e34be95ec111a37bb476abfe85
Gerrit-Change-Number: 64352
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Sun, 15 May 2022 14:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment