[S] Change in flashrom[master]: flashrom.c: Guard against sending spi commands on non-spi mst - flashrom-gerrit

1 Jan 2023


      Attention is currently required from: Felix Singer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71269 )
Change subject: flashrom.c: Guard against sending spi commands on non-spi mst
......................................................................
Patch Set 1:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71269/comment/000f2c2a_7211e799 
PS1, Line 1937: spi_master_no_4ba_modes
Wouldn't it make more sense to add the bustype check inside this function?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7cce4f9c032d33c01bf616e27a50b9727a40fe1b
Gerrit-Change-Number: 71269
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sun, 01 Jan 2023 18:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment