Attention is currently required from: Angel Pons, Nikolai Artemiev.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53946 )
Change subject: flashchips.c: add support for W25Q32JW...M
......................................................................
Patch Set 6:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/53946/comment/0e3985ce_408db8be
PS1, Line 17583: ..IM
Angel - I think we're safe w.r.t. device IDs. The 3.3V and 1.8V parts have different device IDs: […]
Oh wait, I was looking at the wrong datasheets. The W25Q32JW and W25Q32FV chips do share IDs between 1.8V and 3.3V parts when the W25Q32FV is operating in QPI mode:
W25Q32JW: https://www.winbond.com/resource-files/W25Q32JW%20SPI%20RevH%2003172020%20Pl...
W25Q32JW-IQ 15h 6016h
W25Q32JW-IM* 15h 8016h
W25Q32FV: https://www.winbond.com/resource-files/w25q32fv%20revj%2006032016.pdf
W25Q32FV (SPI Mode) 15h 4016h
W25Q32FV (QPI Mode) 15h 6016h
*sigh*
--
To view, visit
https://review.coreboot.org/c/flashrom/+/53946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7425e12658dd69c4ec8d3309dd591d09a935bb4d
Gerrit-Change-Number: 53946
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sun, 16 May 2021 23:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment