Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS
Both uses INB/OUTB and hence should be marked as NEED_RAW_ACCESS in the makefiles; fixing.
Signed-off-by: Victor Ding victording@google.com Change-Id: I6fafd9f59d06f60e9491e3e059c1205d48d8232e --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/46811/1
diff --git a/Makefile b/Makefile index 8af7042..3a0748c 100644 --- a/Makefile +++ b/Makefile @@ -898,11 +898,13 @@ ifeq ($(CONFIG_ENE_LPC), yes) FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1' PROGRAMMER_OBJS += ene_lpc.o +NEED_RAW_ACCESS += CONFIG_ENE_LPC endif
ifeq ($(CONFIG_MEC1308), yes) FEATURE_CFLAGS += -D'CONFIG_MEC1308=1' PROGRAMMER_OBJS += mec1308.o +NEED_RAW_ACCESS += CONFIG_MEC1308 endif
ifeq ($(CONFIG_SERPROG), yes)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG@9 PS1, Line 9: uses use
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG@10 PS1, Line 10: ; fixing drop `fixing`
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/46811
to look at the new patch set (#2).
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS
Both use INB/OUTB and hence should be marked as NEED_RAW_ACCESS in the makefile.
Signed-off-by: Victor Ding victording@google.com Change-Id: I6fafd9f59d06f60e9491e3e059c1205d48d8232e --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/46811/2
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG@9 PS1, Line 9: uses
use
Done
https://review.coreboot.org/c/flashrom/+/46811/1//COMMIT_MSG@10 PS1, Line 10: ; fixing
drop `fixing`
Done
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS ......................................................................
Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS
Both use INB/OUTB and hence should be marked as NEED_RAW_ACCESS in the makefile.
Signed-off-by: Victor Ding victording@google.com Change-Id: I6fafd9f59d06f60e9491e3e059c1205d48d8232e Reviewed-on: https://review.coreboot.org/c/flashrom/+/46811 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/Makefile b/Makefile index 8af7042..3a0748c 100644 --- a/Makefile +++ b/Makefile @@ -898,11 +898,13 @@ ifeq ($(CONFIG_ENE_LPC), yes) FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1' PROGRAMMER_OBJS += ene_lpc.o +NEED_RAW_ACCESS += CONFIG_ENE_LPC endif
ifeq ($(CONFIG_MEC1308), yes) FEATURE_CFLAGS += -D'CONFIG_MEC1308=1' PROGRAMMER_OBJS += mec1308.o +NEED_RAW_ACCESS += CONFIG_MEC1308 endif
ifeq ($(CONFIG_SERPROG), yes)
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Victor Ding (Code Review)