Attention is currently required from: Martin L Roth, Thomas Heijligen, Arthur Heymans, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 )
Change subject: flashrom: rename sb600spi.c to amd_spi.c
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Thinking a bit more about it, and returning back to the point of the patch. I like amd_spi. […]
Given that "sb600_spi" actually supports more chipsets than just sb600, it makes sense to remove "sb600" from the name.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a
Gerrit-Change-Number: 74952
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 10 May 2023 11:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment