Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83998?usp=email )
Change subject: flashchips: add GD25B256E and GD25R256E ......................................................................
Patch Set 1:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83998/comment/94c32829_a58e3c9e?usp... : PS1, Line 7461: FEATURE_WRSR_EXT2
From the datasheet you linked, I think `FEATURE_WRSR_EXT2` not needed. […]
Agree, will remove it and upload again
https://review.coreboot.org/c/flashrom/+/83998/comment/b366e3e3_113c7a56?usp... : PS1, Line 7493: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
I think this needs SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD if all the models have BP4
agree, will change it and upload again.
-
Victor Lim (Code Review)