[M] Change in flashrom[main]: tests: Check verify op completed in full if chip memory modified

[Peter Marheine (Code Review)]

Attention is currently required from: Anastasia Klimchuk.

Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84078?usp=email )

Change subject: tests: Check verify op completed in full if chip memory modified
......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/84078/comment/df163ae7_0d9344df?usp... :
PS1, Line 18: Note: at the moment the test is not fully working, the following
            : write test cases fail (all erase test cases pass):
Looks like it might be a fencepost error (possibly treating the upper bound of a region as exclusive rather than inclusive), since it looks like the unverified bytes might always fall at the end of a region.

File tests/erase_func_algo.c:

https://review.coreboot.org/c/flashrom/+/84078/comment/b54fe4e7_102f0525?usp... :
PS1, Line 60: uint8_t
Since this is true/false, just use `bool`.

https://review.coreboot.org/c/flashrom/+/84078/comment/a966e2b2_5bc432f5?usp... :
PS1, Line 77: == 0x1
I'd rather use implicit boolean conversion throughout (`if (g_state.was_modified[start])`).