Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Subrata Banik.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email )
Change subject: ich: Add names for region 5, 9, 10, 11, 12, 15 ......................................................................
Patch Set 7:
(1 comment)
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/81356/comment/910f6bd8_7f65b6da : PS5, Line 42: 10GbE0 Currently it looks like: ``` --- Details --- Region 0 (Descr. ) 0x00000000 - 0x00000000 Region 1 (BIOS ) 0x00000000 - 0x00000000 Region 2 (ME ) 0x00000000 - 0x00000000 Region 3 (GbE ) is unused. Region 4 (Platf. ) is unused. Region 5 (DevExp ) is unused. Region 6 (BIOS2 ) is unused. Region 7 (unknown) is unused. Region 8 (EC/BMC ) is unused. Region 9 (unknown) 0x00000000 - 0x00000000 Region 10 (IE ) is unused. Region 11 (10GbE0 ) is unused. Region 12 (10GbE1 ) is unused. Region 13 (unknown) is unused. Region 14 (unknown) is unused. Region 15 (PTT ) is unused.
=== Master Section === FLMSTR1 0x00000000 FLMSTR2 0x00000000 ```
Is it true then, that for C620 the tool will print 10GbE1 instead of OpROM ?
The OpROM is located on 10GbE#2, not 10GbE#1. While I considered changing the output to: `Region 12 (10GbE1/OpROM) is unused.`
...this would require significant code modifications due to padding width adjustments. I've decided to postpone this change for now.
I just want to fully understand.
Absolutely! This is a complex area with some documentation being confidential. I've definitely gained insights while working on this CL.