Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not build a test if its driver is not built ......................................................................
Patch Set 2:
(1 comment)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/55295/comment/37d416c3_fbf16b73 PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */
or […]
Thank you for inspiration! now this looks much better, and only one file needs to have guards. The reason I added #if is because when for example CONFIG_MEC1308=no then PROGRAMMER_MEC1308 does not exist and does not compile (because it is guarded by CONFIG_MEC1308, it would be "error: ‘PROGRAMMER_MEC1308’ undeclared"). PROGRAMMER_MEC1308 will change to &programmer_mec1308 after CB:55121 but still guarded. I am fine with empty test which runs and does nothing, but I want everything to build even if defaults are changed.