Attention is currently required from: Alexander Goncharov, DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81350?usp=email )
Change subject: flashchips: Add support for MXIC MX25L12850F ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/81350/comment/f4711261_b90961e8 : PS1, Line 10: wp Could you please mention the commands you ran? Since there are multiple commands for WP, if you list the ones you ran that would be great.
Patchset:
PS1:
MX25L12845E and MX25L12865E have no configuration register.
Yes right, the difference is in configuration register which changes the way `.reg_bits` need to be defined for the chips. Existing entry for `MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F` has no reg_bits currently, but if there were to be added at some point that would be different than what MX25L12850F has.
Meanwhile the newer model MX25L12850F can have all set of operations defined, so users can use all this and not be constrained by older models.
For complete context, existing monolithic entry `MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F` can be split further because out of the five models, they have would slightly different reg_bits config. But they can be split later, if at some point write-protect support would be added to any of them (which means you would have to define exact reg_bits).
Also Joursoir, I am so happy to see you here again !! :)
PS1: Daniel thank you! I think it's much better to update one chip at a time, one per commit. So you did the right thing.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81350/comment/581c3430_73fc5317 : PS1, Line 9051: MACRONIX_MX25L12805D Could you please append the model name (MX25L12850F) to a comment in `include/flashchips.h` for the macro `MACRONIX_MX25L12805D` ? I know it's a long comment already, but let's add one more id at the end of it.
-
Anastasia Klimchuk (Code Review)