Change in flashrom[master]: chipset_enable.c: Remove futile attempt to disable lock

[Andy Pont (Code Review)]

Andy Pont has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48643 )


Change subject: chipset_enable.c: Remove futile attempt to disable lock
......................................................................

chipset_enable.c: Remove futile attempt to disable lock

For all recent Intel chipsets (and possibly others) the ability to
disable the lock fails.  This leads to confusing messages being
presented to the user where unlocking fails but the flash update
process works correctly.

Remove the unlock attempt which had alreayd been marked in the source
code comments as "futile".

Signed-off-by: Andy Pont <[e-mail]>
Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b
---
M chipset_enable.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48643/1

diff --git a/chipset_enable.c b/chipset_enable.c
index 9205d0e..3ca6ba8 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -333,7 +333,6 @@
 		wanted |= (1 << 2);
 
 	wanted |= (1 << 0); /* Set BIOS Write Enable */
-	wanted &= ~(1 << 1); /* Disable lock (futile) */
 
 	/* Only write the register if it's necessary */
 	if (wanted != old) {

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/48643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b
Gerrit-Change-Number: 48643
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Pont <[e-mail]>
Gerrit-MessageType: newchange

[Andy Pont (Code Review)]

Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48643 )

Change subject: chipset_enable.c: Remove futile attempt to disable lock
......................................................................


Patch Set 1:

As per the discussion on IRC on 14 Dec 2020 patch to remove the futile unlock attempt.


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/48643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b
Gerrit-Change-Number: 48643
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Pont <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 15 Dec 2020 12:19:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48643 )

Change subject: chipset_enable.c: Remove futile attempt to disable lock
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/48643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b
Gerrit-Change-Number: 48643
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Pont <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 15 Dec 2020 19:18:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[XS] Change in flashrom[main]: chipset_enable.c: Remove futile attempt to disable lock

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Andy Pont.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48643?usp=email )

Change subject: chipset_enable.c: Remove futile attempt to disable lock
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
Angel, Andy, what is the state of the patch? It has been approved 3 years ago and then never merged?! I am wondering, it is still valid? then it can be rebased, re-approved and finally merged? Thank you!



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/48643?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Id70e132f8feb7b91cbf79d8cdf07744f8763e11b
Gerrit-Change-Number: 48643
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Pont <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Anastasia Klimchuk <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-Attention: Andy Pont <[e-mail]>
Gerrit-Comment-Date: Sat, 25 Nov 2023 12:43:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment