Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/62745/comment/d019a266_34ca64b7 PS1, Line 4: ${WARNERROR-yes}
Maybe just add a colon. so that it is very clear? I mean […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless@tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Mon, 30 May 2022 04:30:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Martin L Roth (Code Review)