Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50711 )
Change subject: tree: Remove forward-declarations for spi masters ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/50711/comment/240169a0_b358a55c PS1, Line 7: Removing
nit: Remove
Done
https://review.coreboot.org/c/flashrom/+/50711/comment/89a9b162_2fa0d680 PS1, Line 9: Reordering
nit: Reorder
Done
Patchset:
PS2: thank you for quick review!
File dummyflasher.c:
PS1:
This one is large, can we do it in a separate patch please?
https://review.coreboot.org/c/flashrom/+/50712
File serprog.c:
PS1:
Likewise what Angel said about dummyflasher.c, serprog. […]
https://review.coreboot.org/c/flashrom/+/50713
-
Anastasia Klimchuk (Code Review)