Change in flashrom[master]: cli_classic.c: fix minor cosmetic bug when support for wiki page gene...
Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48430 ) Change subject: cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in ...................................................................... cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 --- M cli_classic.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/48430/1 diff --git a/cli_classic.c b/cli_classic.c index ae7f6ef..3dbaec2 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -364,7 +364,7 @@ cli_classic_validate_singleop(&operation_specified); list_supported_wiki = 1; #else - cli_classic_abort_usage("Error: Wiki output was not" + cli_classic_abort_usage("Error: Wiki output was not " "compiled in. Aborting.\n"); #endif break; -- To view, visit https://review.coreboot.org/c/flashrom/+/48430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Gerrit-Change-Number: 48430 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer@gmail.com> Gerrit-MessageType: newchange
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/48430 to look at the new patch set (#2). Change subject: cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in ...................................................................... cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Signed-off-by: Idwer Vollering <vidwer@gmail.com> --- M cli_classic.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/48430/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/48430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Gerrit-Change-Number: 48430 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48430 ) Change subject: cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/48430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Gerrit-Change-Number: 48430 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 07 Dec 2020 23:32:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Idwer Vollering has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48430 ) Change subject: cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in ...................................................................... cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Signed-off-by: Idwer Vollering <vidwer@gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/48430 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M cli_classic.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index ae7f6ef..3dbaec2 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -364,7 +364,7 @@ cli_classic_validate_singleop(&operation_specified); list_supported_wiki = 1; #else - cli_classic_abort_usage("Error: Wiki output was not" + cli_classic_abort_usage("Error: Wiki output was not " "compiled in. Aborting.\n"); #endif break; -- To view, visit https://review.coreboot.org/c/flashrom/+/48430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937 Gerrit-Change-Number: 48430 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (2)
-
Angel Pons (Code Review) -
Idwer Vollering (Code Review)