Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 )
Change subject: meson.build: Sanitize the version string
......................................................................
Patch Set 5: Code-Review+2
I guess it's slightly odd just to not post-release bump the version, but looks good to me.
What would be the benefit compared to automatically bumping
it when tagging a release?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545
Gerrit-Change-Number: 35566
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Limonciello
superm1@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Mario Limonciello
superm1@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Oct 2019 19:21:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment