Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Anton Samsonov, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email )
Change subject: Remove dependency on C23 __has_include()
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS1:
I totally agree with all your and Alexander's propositions, however have no knowledge of how to test […]
Well done, thank you!
Please try using `cc.check_header` in Meson to check whether the specified header is usable. You can find an example by searching for `cc.check_header('sys/utsname.h')`. I assume that all tests will then be verified by Jenkins.
File Makefile:
https://review.coreboot.org/c/flashrom/+/77089/comment/5243b176_7772b912 :
PS3, Line 209:
drop extra line
https://review.coreboot.org/c/flashrom/+/77089/comment/b87050e5_3eb13c3b :
PS3, Line 240:
drop extra line
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6
Gerrit-Change-Number: 77089
Gerrit-PatchSet: 3
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Anton Samsonov
avscomputing@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anton Samsonov
avscomputing@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Comment-Date: Sun, 29 Oct 2023 20:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anton Samsonov
avscomputing@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment